Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a job for existing tests in ambient mode #5001

Closed
wants to merge 1 commit into from

Conversation

stevenctl
Copy link
Contributor

@stevenctl stevenctl commented Sep 7, 2023

This deserves some discussion, but I think it adds valuable coverage.
It could also be accomplished by forcing the "everywhere" mode in Go code.

This invocation without the ambient.everywhere flag results in mostly testing sidecars (I think with HBONE turned on?). We end up skipping a lot. If we grep down to to_waypoint|from_captured|to_captured we only gain coverage on the virtualservice cases.

When we run with the everywhere flag, pretty much all our apps get a waypoint. This means we cover pretty much all of the L7 functionality. (That isn't explicitly skipped, which is still a lot).

2023-09-07T19:36:29.084617Z	info	tf	adding waypoint to /a
2023-09-07T19:36:29.084623Z	info	tf	adding waypoint to /b
2023-09-07T19:36:29.084627Z	info	tf	adding waypoint to /c
2023-09-07T19:36:29.084631Z	info	tf	adding waypoint to /headless
2023-09-07T19:36:29.084635Z	info	tf	adding waypoint to /statefulset
2023-09-07T19:36:29.084640Z	info	tf	adding waypoint to /naked
2023-09-07T19:36:29.084644Z	info	tf	adding waypoint to /tproxy
2023-09-07T19:36:29.084649Z	info	tf	adding waypoint to /vm

I intend to expand this job to run pilot rather than ambient with -run TestTraffic. That will rely on istio/istio#46863 and enumerating valuable tests/and valid skips.

@stevenctl stevenctl requested a review from a team as a code owner September 7, 2023 19:51
@istio-policy-bot
Copy link

😊 Welcome @stevenctl! This is either your first contribution to the Istio test-infra repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2023
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 29, 2024
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevenctl stevenctl closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants