add a job for existing tests in ambient mode #5001
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deserves some discussion, but I think it adds valuable coverage.
It could also be accomplished by forcing the "everywhere" mode in Go code.
This invocation without the ambient.everywhere flag results in mostly testing sidecars (I think with HBONE turned on?). We end up skipping a lot. If we grep down to
to_waypoint|from_captured|to_captured
we only gain coverage on thevirtualservice
cases.When we run with the everywhere flag, pretty much all our apps get a waypoint. This means we cover pretty much all of the L7 functionality. (That isn't explicitly skipped, which is still a lot).
I intend to expand this job to run
pilot
rather thanambient
with-run TestTraffic
. That will rely on istio/istio#46863 and enumerating valuable tests/and valid skips.